[PATCH] D140382: [CodeGen] Add user interface for DetectDeadLanes

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 11:32:35 PST 2023


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/DetectDeadLanes.h:96
+
+  std::pair<bool, bool> ModifySubRegisterOperandStatus(MachineFunction &MF);
+
----------------
Needs comment, I don't know what the two return values mean. 


================
Comment at: llvm/lib/CodeGen/DetectDeadLanes.cpp:473
             if (CrossCopy)
               Again = true;
           }
----------------
I don't really understand what again is supposed to mean (but I guess this was the case before too)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140382/new/

https://reviews.llvm.org/D140382



More information about the llvm-commits mailing list