[PATCH] D140382: [CodeGen] Add user interface for DetectDeadLanes

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/DetectDeadLanes.cpp:440
+std::pair<bool, bool>
+DetectDeadLanes::ModifySubRegisterOperandStatus(MachineFunction &MF) {
   bool Changed = false;
----------------
Function names should be start with a lower case letter


================
Comment at: llvm/lib/CodeGen/DetectDeadLanes.cpp:504
+    std::tie(LocalChanged, Again) = ModifySubRegisterOperandStatus(MF);
+    computeSubRegisterLaneBitInfo();
     Changed |= LocalChanged;
----------------
We don't need to call computeSubRegisterLaneBitInfo if ModifySubRegisterOperandStatus didn't change anything


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140382/new/

https://reviews.llvm.org/D140382