[PATCH] D141048: [SelectionDAG] Add missing setValue calls in visitIntrinsicCall
Martin Fink via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 5 06:56:50 PST 2023
martin-fink added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/SelectionDAG/arm64-pcsections-selectiondag.ll:87-100
+ ; CHECK-LABEL: name: call_memcpy_element_unordered_atomic_intrinsic
+ ; CHECK: bb.0 (%ir-block.0):
+ ; CHECK-NEXT: liveins: $lr
+ ; CHECK-NEXT: {{ $}}
+ ; CHECK-NEXT: early-clobber $sp = frame-setup STRXpre killed $lr, $sp, -16 :: (store (s64) into %stack.2)
+ ; CHECK-NEXT: frame-setup CFI_INSTRUCTION def_cfa_offset 16
+ ; CHECK-NEXT: frame-setup CFI_INSTRUCTION offset $w30, -16
----------------
melver wrote:
> I see no pcsections, is it still missing?
I think I've overlooked that `pcsections` are not passed to MIR for the `.element.unordered.atomic` instrinsics on AArch64.
As the issue for that probably lies somewhere else and not in the scope of this commit (the pcsections are passed to MIR on X86, for example), I would suggest that I (for now) remove these three functions from the test in this commit and have a look at them later on.
What do you think about that?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141048/new/
https://reviews.llvm.org/D141048
More information about the llvm-commits
mailing list