[PATCH] D141048: [SelectionDAG] Add missing setValue calls in visitIntrinsicCall

Thu Jan 5 06:47:33 PST 2023

arsenm added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/SelectionDAG/arm64-pcsections-selectiondag.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -stop-after=aarch64-expand-pseudo -verify-machineinstrs | FileCheck %s
----------------
melver wrote:
> Similar to x86 comment:
> 
> I think we want to say -global-isel=0, to ensure GlobalISel isn't used?
> 
> Also, just call it similar to the x86 one 'pcsections-memtransfer.ll', i.e. it'll end up in 'CodeGen/AArch64/pcsections-memtransfer.ll'.
Just because it's a test for sdag doesn't mean it also shouldn't pass for globalisel. I wouldn't explicitly turn it off

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141048/new/

https://reviews.llvm.org/D141048