[PATCH] D140398: [AArch64] Add SVE int instructions to isAssociativeAndCommutative

Thu Jan 5 03:41:00 PST 2023

kawashima-fj marked an inline comment as done.
kawashima-fj added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/machine-combiner-eor.mir:5
+
+# Most machine-combiner reassociation tests are put in machine-combiner.ll.
+# However, we cannot test reassociation of SVE EORs in machine-combiner.ll
----------------
dmgreen wrote:
> I believe that eor3 is SVE2, and eor is SVE. So with the right target features it should be possible to test in a ll file too.
> This test sounds good though instead. It can be good to test passes in isolation too.
Yes, `EOR3` is SVE2. However, I want to test `MUL <Zd>.<T>, <Zn>.<T>, <Zm>.<T>`, which was introduced in SVE2, in `machine-combiner.ll`. So I want `sve2` target feature in `machine-combiner.ll`.
Adding a `RUN` line to test both `+sve2` and `+nosve2` will resolve the problem but will uselessly increase unrelated `CHECK` lines.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140398/new/

https://reviews.llvm.org/D140398