[PATCH] D140398: [AArch64] Add SVE int instructions to isAssociativeAndCommutative

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 00:26:25 PST 2023


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks. LGTM



================
Comment at: llvm/test/CodeGen/AArch64/machine-combiner-eor.mir:5
+
+# Most machine-combiner reassociation tests are put in machine-combiner.ll.
+# However, we cannot test reassociation of SVE EORs in machine-combiner.ll
----------------
I believe that eor3 is SVE2, and eor is SVE. So with the right target features it should be possible to test in a ll file too.
This test sounds good though instead. It can be good to test passes in isolation too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140398/new/

https://reviews.llvm.org/D140398



More information about the llvm-commits mailing list