[PATCH] D141003: [LoopVectorizer] Fix inloop reductions mask placement

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 01:07:03 PST 2023


fhahn accepted this revision.
fhahn added a comment.

LGTM, thanks!



================
Comment at: llvm/test/Transforms/LoopVectorize/reduction-inloop.ll:1125
 
+; This case was previously failing verification due to the mask for the
+; reduction being created after the reduction.
----------------
SjoerdMeijer wrote:
> Nit, perhaps: verification -> vplan validation ?
I think what fails is the VPlan verifier, so VPlan verification would probably be best.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141003/new/

https://reviews.llvm.org/D141003



More information about the llvm-commits mailing list