[PATCH] D141003: [LoopVectorizer] Fix inloop reductions mask placement

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 01:01:22 PST 2023


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks like a good fix to me.
Perhaps wait a day in case there are other ideas about that.



================
Comment at: llvm/test/Transforms/LoopVectorize/reduction-inloop.ll:1125
 
+; This case was previously failing verification due to the mask for the
+; reduction being created after the reduction.
----------------
Nit, perhaps: verification -> vplan validation ?


================
Comment at: llvm/test/Transforms/LoopVectorize/reduction-inloop.ll:1213
+
+; This case was previously failing verification due to the mask for the
+; reduction being created after the reduction.
----------------
same


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141003/new/

https://reviews.llvm.org/D141003



More information about the llvm-commits mailing list