[PATCH] D140847: [BOLT] Modify the print option to a meaningful value

[hezuoqiang via Phabricator via llvm-commits]

hzq created this revision.
Herald added a reviewer: rafauler.
Herald added subscribers: treapster, ayermolo.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
hzq updated this revision to Diff 485869.
hzq added a comment.
hzq updated this revision to Diff 486265.
hzq added a comment.
hzq edited the summary of this revision.
hzq published this revision for review.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

Update commit info.


Using the option `-print-sorted-by=.` cause to core dump, so change to a legal value.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140847

Files:
  bolt/lib/Passes/BinaryPasses.cpp


Index: bolt/lib/Passes/BinaryPasses.cpp
===================================================================
--- bolt/lib/Passes/BinaryPasses.cpp
+++ bolt/lib/Passes/BinaryPasses.cpp
@@ -122,22 +122,19 @@
                   cl::desc("print statistics about basic block ordering"),
                   cl::init(0), cl::cat(BoltOptCategory));
 
-static cl::list<bolt::DynoStats::Category>
-PrintSortedBy("print-sorted-by",
-  cl::CommaSeparated,
-  cl::desc("print functions sorted by order of dyno stats"),
-  cl::value_desc("key1,key2,key3,..."),
-  cl::values(
+static cl::list<bolt::DynoStats::Category> PrintSortedBy(
+    "print-sorted-by", cl::CommaSeparated,
+    cl::desc("print functions sorted by order of dyno stats"),
+    cl::value_desc("key1,key2,key3,..."),
+    cl::values(
 #define D(name, ...)                                        \
     clEnumValN(bolt::DynoStats::name,                     \
                dynoStatsOptName(bolt::DynoStats::name),   \
                dynoStatsOptDesc(bolt::DynoStats::name)),
-    DYNO_STATS
+        DYNO_STATS
 #undef D
-    clEnumValN(0xffff, ".", ".")
-    ),
-  cl::ZeroOrMore,
-  cl::cat(BoltOptCategory));
+            clEnumValN(bolt::DynoStats::LAST_DYNO_STAT, ".", ".")),
+    cl::ZeroOrMore, cl::cat(BoltOptCategory));
 
 static cl::opt<bool>
     PrintUnknown("print-unknown",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140847.486265.patch
Type: text/x-patch
Size: 1343 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230105/1d95ad7a/attachment.bin>