[PATCH] D119049: [LLD] Allow usage of LLD as a library

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/Common/CMakeLists.txt:34
   Filesystem.cpp
+  LLDLibrary.cpp
   Memory.cpp
----------------
Can we come up with a better name for this file maybe?  That name makes me think its specifically for the library use case but that isn't true.

Also, we don't capitalize lld elsewhere, with in the filenames or directory names.

How about `lldMain.cpp`, or perhaps we can come up with a name that doesn't start with `lld` at all?   




================
Comment at: lld/include/lld/Common/Driver.h:27
 // by cleanup.
-SafeReturn safeLldMain(int argc, const char **argv, llvm::raw_ostream &stdoutOS,
+SafeReturn safeLldMain(std::vector<const char *> &args,
+                       llvm::raw_ostream &stdoutOS,
----------------
Why not `llvm::ArrayRef<const char *>`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119049/new/

https://reviews.llvm.org/D119049