[PATCH] D119049: [LLD] Allow usage of LLD as a library

Wed Jan 4 09:51:36 PST 2023

aganea added inline comments.

================
Comment at: lld/tools/lld/lld_lib.cpp:204
+LLVM_WEAK_SYMBOL(
+    ?link at coff@lld@@YA_NV?$ArrayRef at PEBD@llvm@@AEAVraw_ostream at 4@1_N2 at Z,
+    ?alt_link at coff@lld@@YA_NV?$ArrayRef at PEBD@llvm@@AEAVraw_ostream at 4@1_N2 at Z)
----------------
mstorsjo wrote:
> This is the MSVC specific C++ mangling, and doesn't work as such for the non-MSVC version of `LLVM_WEAK_SYMBOL` here.
Fixed. Using the default OBJ-in-LIB override mechanism now, as described well by Raymond Chen [[ https://devblogs.microsoft.com/oldnewthing/20130109-00/?p=5613 | here ]].

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119049/new/

https://reviews.llvm.org/D119049