[PATCH] D139883: [llvm][CallBrPrepare] add llvm.callbr.landingpad intrinsic

[Bill Wendling via Phabricator via llvm-commits]

void added a comment.

In D139883#4024498 <https://reviews.llvm.org/D139883#4024498>, @efriedma wrote:

> The use of an IR pass here is basically just a hack to work around the fact that SelectionDAG doesn't have a reasonable way to do this lowering inside SelectionDAG itself.  If we were using GlobalISel exclusively, we would probably just implement this as a GlobalISel pass instead of an IR pass.
>
> If we need some additional infrastructure to make the IR pass work reliably, we can look at that, but implementing an IR instruction that only exists for a couple passes inside codegen seems like overkill.

Thanks. Okay, I agree with @efriedma and you that an intrinsic should work just fine here. It seems like the lifespan of this intrinsic is going to be very short, so much so that few if any IR changes will occur.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139883/new/

https://reviews.llvm.org/D139883