[PATCH] D133715: [ADT] Add HashMappedTrie

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 13:01:16 PST 2023


steven_wu marked 9 inline comments as done.
steven_wu added inline comments.


================
Comment at: llvm/unittests/ADT/HashMappedTrieTest.cpp:199
+    operator NumT() const { return Num; }
+    ~NumWithDestructorT() {}
+  };
----------------
dblaikie wrote:
> This is specifically to make it non-trivially destructible? should this record the execution of the dtor and check that the right number (or even instance) of destructions occur?
The test is for making sure no recursion happening when destroying a large Trie with objects inside (with or without destructor). The order doesn't matter. I added comment to clarify.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133715/new/

https://reviews.llvm.org/D133715



More information about the llvm-commits mailing list