[PATCH] D133715: [ADT] Add HashMappedTrie

[Steven Wu via Phabricator via llvm-commits]

steven_wu updated this revision to Diff 486055.
steven_wu added a comment.

Address review feedback and rebase the patch using std::optional

Still thinking how to unittest without string compare. The only way I can think is to implement iteration on HashMappedTrie so we can have API to check the state of SubTrie. That will expose more types to user, which will make API more complicated.

Also for discussion of names, do we have other candidates to replace "HashMappedTrie" that is better and clearer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133715/new/

https://reviews.llvm.org/D133715

Files:
  llvm/include/llvm/ADT/HashMappedTrie.h
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/HashMappedTrie.cpp
  llvm/lib/Support/HashMappedTrieIndexGenerator.h
  llvm/unittests/ADT/CMakeLists.txt
  llvm/unittests/ADT/HashMappedTrieTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133715.486055.patch
Type: text/x-patch
Size: 45282 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230103/ca23863d/attachment.bin>