[PATCH] D140883: [AMDGPU] Simplify getNumFlatOffsetBits. NFC.

Tue Jan 3 06:49:45 PST 2023

foad added a comment.

> The AllowNegative thing feels a bit alien to the ISA, effectively adding an extra concept while not eliminating the need for adjustments.

Then I think we simply disagree about which one is conceptually simpler.

================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:7935

-  bool Signed = FlatVariant != SIInstrFlags::FLAT;
+  bool AllowNegative = FlatVariant != SIInstrFlags::FLAT;
   if (ST.hasNegativeScratchOffsetBug() &&
----------------
arsenm wrote:
> I don't really like the AllowNegative naming. SignBitIgnored?
I don't think "ignored" is right. In at least some cases (like hasNegativeScratchOffsetBug) it is definitely not ignored but leads to wrong behaviour.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140883/new/

https://reviews.llvm.org/D140883