[PATCH] D140883: [AMDGPU] Simplify getNumFlatOffsetBits. NFC.

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added a comment.

By actual width I mean what can be passed to `isIntN()`/`isUInt()` without adjustments. The `AllowNegative` thing feels a bit alien to the ISA, effectively adding an extra concept while not eliminating the need for adjustments. Signedness, in contrast, looks rather natural and familiar, and `if (Signed ? isIntN(...) : isUIntN(...))` is probably easier to understand than `if (!isIntN(...) || (!AllowNegative && Op.getImm() < 0))`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140883/new/

https://reviews.llvm.org/D140883