[PATCH] D140751: Implement a FIXME for better poison handling in SimplifyCFG.

Owen Anderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 1 20:28:58 PST 2023


resistor added a comment.

I don't have a test that exercises this, just following up on the FIXME comments.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:341
+      return true;
+    if (isa<PoisonValue>(IV1) && !isa<PoisonValue>(IV0))
+      return true;
----------------
nikic wrote:
> The `!isa<PoisonValue>` checks shouldn't be necessary.
Why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140751/new/

https://reviews.llvm.org/D140751



More information about the llvm-commits mailing list