[PATCH] D140570: [AVR] Optimize 32-bit shift: move bytes around

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 1 18:54:42 PST 2023


benshi001 accepted this revision.
benshi001 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:1878
+  // zero the bottom registers.
+  while (ShiftLeft && ShiftAmt >= 8) {
+    // Move all registers one to the left.
----------------
This can be `for (; ShiftLeft && ShiftAmt >= 8; ShiftAmt -= 8)` as you did in the next loop.

You can change that while committing. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140570/new/

https://reviews.llvm.org/D140570



More information about the llvm-commits mailing list