[PATCH] D140777: [AVR] Fix some ambiguous cases in AsmParser

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 1 17:57:31 PST 2023


benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AsmParser/AVRAsmParser.cpp:659
+    } else if (OperandNum == 0) {
+      std::array<StringRef, 8> Insts = {"sts", "call", "rcall", "rjmp", "jmp"};
+      for (auto Inst : Insts) {
----------------
there may be other instructions which need a careful check. So I temporarily give the array a length=8.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140777/new/

https://reviews.llvm.org/D140777



More information about the llvm-commits mailing list