[PATCH] D140777: [AVR] Fix some ambiguous cases in AsmParser

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 1 17:54:54 PST 2023


benshi001 marked 3 inline comments as done.
benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AsmParser/AVRAsmParser.cpp:649
+    if (OperandNum == 2) {
+      SmallVector<StringRef, 8> Insts = {"lds", "adiw", "sbiw", "ldi"};
+      for (auto Inst : Insts)
----------------
aykevl wrote:
> `std::array` is probably a better choice in this case. See: https://reviews.llvm.org/D140569#inline-1358484
> 
> Also: can you add a test for `adiw` and `sbiw`?
Done. Changed to `std::array`, and also tests for `adiw`/`sbiw` are added.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140777/new/

https://reviews.llvm.org/D140777



More information about the llvm-commits mailing list