[PATCH] D140815: [AVR] Fix incorrect decoding of RJMP and RCALL

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 1 17:11:31 PST 2023


benshi001 added a comment.

In D140815#4021212 <https://reviews.llvm.org/D140815#4021212>, @aykevl wrote:

> Shouldn't this also affect llvm/test/MC/AVR/inst-rjmp.s?
> In any case, I think it's better to (also) have tests in llvm/test/MC/AVR for this.

Actually this bug does not affect `llvm/test/MC/AVR/inst-rjmp.s`, so I can not add any test in `llvm/test/MC/AVR`.

Since llvm-objdump decodes all address offsets of `rjmp`/'rcall` (before linking) to 0, also you can see those zeros in `llvm/test/MC/AVR/inst-rjmp.s`, which are not affected.

llvm-objdump only affects address offsets of `rjmp`/'rcall` that are after linking, so we have to test them in the lld tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140815/new/

https://reviews.llvm.org/D140815



More information about the llvm-commits mailing list