[PATCH] D140747: [Transform] Rewrite LowerSwitch using APInt

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LowerSwitch.cpp:358
+  Value *Val = SI->getCondition(); // The value we are switching on...
+  BasicBlock *Default = SI->getDefaultDest();
 
----------------
Please remove / pre-commit any clang-format only changes to untouched code


================
Comment at: llvm/lib/Transforms/Utils/LowerSwitch.cpp:441
+    SignedMax.setAllBits();
+    SignedMax.setBitVal(BitWidth - 1, 0);
+    // Signed min: 0b10000....
----------------
Do we not have a static helper to create values like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140747/new/

https://reviews.llvm.org/D140747