[PATCH] D139807: [lld][ELF] Support relocation R_AVR_LDS_STS_16 on AVRTiny devices.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 31 23:35:30 PST 2022


MaskRay added inline comments.


================
Comment at: lld/test/ELF/avr-reloc.s:4
+; RUN: ld.lld %t0.o --defsym=a=0x12345678 --defsym=b=30 -o %t0
+; RUN: llvm-objdump -d --print-imm-hex --mcpu=atmega328p %t0 \
+; RUN:     | FileCheck --check-prefixes=CHECK,AVR %s
----------------
The prevailing style in this directory is to place `|` on the previous line


================
Comment at: lld/test/ELF/avr-reloc.s:53
 
-;; The disassembler is not yet able to decode those opcodes
-;; 9e 8e    std    Y+30, r9
-;; 9e 8c    ldd    r9, Y+30
-;; 4e 96    adiw   r24, 0x1e
+.ifndef tiny
 .section .SIX,"ax", at progbits
----------------
`TINY`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139807/new/

https://reviews.llvm.org/D139807



More information about the llvm-commits mailing list