[PATCH] D139184: [LLD][Windows]Feature "checksum" for Windows PE

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

Looks good generally.

@tonic Does your veto still hold? Can we move ahead with this patch?



================
Comment at: lld/COFF/Writer.cpp:620
+
+  // RFC1071
+  while (count > 1) {
----------------
Could you please expand the comment a bit? Something like « The PE checksum algorithm, implemented as suggested in RFC1071 »


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139184/new/

https://reviews.llvm.org/D139184