[llvm] 902614d - [docs] TestingGuide.rst: Fix incorrect description
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 30 23:31:38 PST 2022
Author: Jie Fu
Date: 2022-12-30T23:31:33-08:00
New Revision: 902614d2542d0aba4b6a5829eb7ea5dd8056fcb0
URL: https://github.com/llvm/llvm-project/commit/902614d2542d0aba4b6a5829eb7ea5dd8056fcb0
DIFF: https://github.com/llvm/llvm-project/commit/902614d2542d0aba4b6a5829eb7ea5dd8056fcb0.diff
LOG: [docs] TestingGuide.rst: Fix incorrect description
This patch fixes two incorrect descriptions in TestingGuide.rst.
1. test/lit.site.cfg --> test/lit.site.cfg.py
After https://reviews.llvm.org/D37838 , the `test/lit.site.cfg` had been added a .py extension.
So it should be `test/lit.site.cfg.py`.
2. $(LLVM_OBJ_ROOT)/$(BuildMode)/bin --> $(LLVM_OBJ_ROOT)/bin
The current build system doesn't create a $(BuildMode) directory any more.
So it should be removed.
Reviewed By: mehdi_amini, MaskRay
Differential Revision: https://reviews.llvm.org/D140780
Added:
Modified:
llvm/docs/TestingGuide.rst
Removed:
################################################################################
diff --git a/llvm/docs/TestingGuide.rst b/llvm/docs/TestingGuide.rst
index bbf8ffed6a517..ac290f91ca64c 100644
--- a/llvm/docs/TestingGuide.rst
+++ b/llvm/docs/TestingGuide.rst
@@ -206,7 +206,7 @@ Writing new regression tests
The regression test structure is very simple, but does require some
information to be set. This information is gathered via ``cmake``
-and is written to a file, ``test/lit.site.cfg`` in the build directory.
+and is written to a file, ``test/lit.site.cfg.py`` in the build directory.
The ``llvm/test`` Makefile does this work for you.
In order for the regression tests to work, each directory of tests must
@@ -235,7 +235,7 @@ as many RUN lines as needed.
:program:`lit` performs substitution on each RUN line to replace LLVM tool names
with the full paths to the executable built for each tool (in
-``$(LLVM_OBJ_ROOT)/$(BuildMode)/bin)``. This ensures that :program:`lit` does
+``$(LLVM_OBJ_ROOT)/bin``). This ensures that :program:`lit` does
not invoke any stray LLVM tools in the user's path during testing.
Each RUN line is executed on its own, distinct from other lines unless
More information about the llvm-commits
mailing list