[PATCH] D140788: [DWARFLinkerNext] add AddressesMap interface.

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: llvm/include/llvm/DWARFLinkerNext/AddressesMap.h:17
+namespace llvm {
+namespace dwarflinker {
+
----------------
There is no `next` in the namespace? You can use nested namespaces.


================
Comment at: llvm/include/llvm/DWARFLinkerNext/AddressesMap.h:38
+  /// \returns true and sets AddrAdjust if it is the case.
+  virtual bool isLiveVariable(const DWARFDie &DIE, int64_t &AddrAdjust) = 0;
+
----------------
Is this the same as returning `std::optional<int64_t>`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140788/new/

https://reviews.llvm.org/D140788