[PATCH] D140460: [RISCV][MC] Add support for experimental zfa extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/MC/RISCV/rv64zfa-valid.s:1
+# RUN: llvm-mc %s -triple=riscv64 -mattr=+experimental-zfa,+d,+zfh -riscv-no-aliases -show-encoding \
+# RUN:     | FileCheck -check-prefixes=CHECK-ASM,CHECK-ASM-AND-OBJ %s
----------------
I don't like the duplicated test content with rv32zfa-valid.s

I believe our usual MC testing is done like this

rv32zfa-valid.s <- test with both riscv32 and riscv64 command lines.
rv32zfa-only-valid.s <- test with riscv32 only instructions that aren't not supported by riscv64


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140460/new/

https://reviews.llvm.org/D140460