[PATCH] D135202: [IR] Add a target extension type to LLVM.

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu added inline comments.


================
Comment at: llvm/lib/IR/Type.cpp:841
+struct TargetTypeInfo {
+  Type *LayoutType;
+  uint64_t Properties;
----------------
Can the LayoutType be struct type, or scalable vector type?


================
Comment at: llvm/lib/IR/Type.cpp:854
+  if (Name.startswith("spirv.")) {
+    return TargetTypeInfo(Type::getInt8PtrTy(C, 0), TargetExtType::HasZeroInit,
+                          TargetExtType::CanBeGlobal);
----------------
Is there anymore better code structure to separate target-specific code to get TargetTypeInfo such as individual hook?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135202/new/

https://reviews.llvm.org/D135202