[PATCH] D140087: [X86] Replace (31/63 -/^ X) with (NOT X) and ignore (32/64 ^ X) when computing shift count

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 29 13:59:02 PST 2022


goldstein.w.n added a comment.

In D140087#4019617 <https://reviews.llvm.org/D140087#4019617>, @lebedev.ri wrote:

> Please be sure to precommit the test changes before committing the change itself.

You want the new tests `invalid_add31` / `invalid_sub31` split into a seperate commit?

> Looks good to me now. Thanks!




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140087/new/

https://reviews.llvm.org/D140087



More information about the llvm-commits mailing list