[PATCH] D140631: [lld-macho][test] Remove redundant -lSystem flags

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

> With that approach, it's not possible to duplicate a run line and make one run line run ld64 and the other old, is it?

Yeah that's a limitation. What I usually do is to run the test once with `-a`, copy the LLD invocation of interest, and use that to invoke ld64.

> Also, imho it's nice if the run line looks similar to what actually runs, without lots of possibly surprising implicit additions.

I can see the value of that, but I also think that there are so many flags that it is sometimes hard to figure out what the important features being tested are. Factoring out the boilerplate helps with that. (In fact I don't think it helps enough... the lit test system seems rather limited in this aspect)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140631/new/

https://reviews.llvm.org/D140631