[PATCH] D140592: [lld-macho] Skip re-loading archive if already loaded

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

So I played around with the test a bit, creating a `has-objc-symbol-2.s` file that is identical except with a section named `has_objc_symbol2` instead of `has_objc_symbol`. There is no dup symbol error either, demonstrating that ld64 isn't hashing contents (at least not the full contents).

Anyway that investigation jogged my memory -- I think this the same issue as https://github.com/llvm/llvm-project/issues/50817#issuecomment-981045478. As that comment indicates, I'd prefer if we fixed the issue in the builds, if that's possible.

We should also document that behavioral difference so we don't forget about it again heh


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140592/new/

https://reviews.llvm.org/D140592