[PATCH] D140585: CodingStandards: restrict CamelCase variable names guideline to llvm/clang/clang-tools-extra/polly/bolt

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 29 10:34:49 PST 2022


MaskRay added a comment.

In D140585#4019417 <https://reviews.llvm.org/D140585#4019417>, @dblaikie wrote:

> FWIW, I don't think there's anymore consensus for this now than when this was proposed. The link in the patch description here is a thread where it's mostly you and me discussing it, without any closure - and a few other folks chiming in with their difficulties. And all of this seems to have had little overlap/involvement of the formal proposal, that's still outstanding, in https://reviews.llvm.org/D59251 / https://llvm.org/docs/Proposals/VariableNames.html .
>
> I'm not sure if @mehdi_amini meant their approval to be "this is good to commit in general" or "for their part, it looks OK, but other folks need buy in"?

The updated wording matches the current status quo and seems the best resolution for today.

https://reviews.llvm.org/D59251 / https://llvm.org/docs/Proposals/VariableNames.html are proposing changing the status quo which is not what I am proposing. I think the coding standards should just reflect the truth for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140585/new/

https://reviews.llvm.org/D140585



More information about the llvm-commits mailing list