[PATCH] D140581: [NVPTX] Enforce minumum alignment of 4 for byval parametrs in a function prototype
Pavel Kopyl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 29 06:17:31 PST 2022
pavelkopyl added a comment.
In D140581#4015109 <https://reviews.llvm.org/D140581#4015109>, @ldrumm wrote:
> In your commit message:
>
> - s/parametrs/parameters
>
> I'd prefer to split off a separate test that only checks the alignment of various calls, rather than reuse the byval bitcast test. Otherwise LGTM, but I'd wait on someone more familiar with ptx, e.g. ~tra
Thank you for review. I added new case for checking .param alignment in function prototype to llvm/test/CodeGen/NVPTX/param-align.ll
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140581/new/
https://reviews.llvm.org/D140581
More information about the llvm-commits
mailing list