[PATCH] D139184: [LLD][Windows]Feature "checksum" for Windows PE

Qfrost via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 29 01:29:15 PST 2022


Qfrost911 updated this revision to Diff 485591.
Qfrost911 added a comment.

Thank you very much.

But I still have some confusion. You mentioned if we post "/RELEASE", we need to compare the value read from llvm-readobj and an expected checksum. But how do I calc an expected checksum using lit tools? Adding RFC1071 in lit test? We cannot determine a unique checksum for each specific yaml, because some values in PE will be changed every time compilation. These values can impact the checksum.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139184/new/

https://reviews.llvm.org/D139184

Files:
  lld/COFF/Config.h
  lld/COFF/Driver.cpp
  lld/COFF/Options.td
  lld/COFF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139184.485591.patch
Type: text/x-patch
Size: 3127 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221229/036e9062/attachment.bin>


More information about the llvm-commits mailing list