[PATCH] D140087: [X86] Replace (31/63 -/^ X) with (NOT X) and ignore (32/64 ^ X) when computing shift count

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D140087#4018605 <https://reviews.llvm.org/D140087#4018605>, @lebedev.ri wrote:

> Can you please add some alive2 proof links into the patch description?



  $> ./build/bin/llvm-lit -vv -Dopt=/home/noah/programs/opensource/llvm-dev/src/alive2/build/opt-alive.sh llvm/test/CodeGen/X86/not-shift.ll
  -- Testing: 1 tests, 1 workers --
  PASS: LLVM :: CodeGen/X86/not-shift.ll (1 of 1)
  
  Testing Time: 0.51s
    Passed: 1
  $> ./build/bin/llvm-lit -vv -Dopt=/home/noah/programs/opensource/llvm-dev/src/alive2/build/opt-alive.sh llvm/test/CodeGen/X86/legalize-shift-64.ll
  -- Testing: 1 tests, 1 workers --
  PASS: LLVM :: CodeGen/X86/legalize-shift-64.ll (1 of 1)
  
  Testing Time: 0.08s
    Passed: 1

Not sure if you meant something else (new the the tool sorry), if so let me know.

Note the AMX tests fail with alive2. I checked and they fail before the patch
was added as well and the patch doesn't change any of codegen in those tests
so have to imagine its unrelated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140087/new/

https://reviews.llvm.org/D140087