[PATCH] D135929: [profile] Add binary ids into indexed profiles

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem updated this revision to Diff 485558.
gulfem added a comment.

There were two issues when I landed the change:

1. Failed on big endian powerpc64 bot

https://lab.llvm.org/buildbot#builders/231/builds/6229
The issue is that we use the host-endian format in raw profiles,
but we always use little-endian format in indexed profiles.
readBinaryIdsInternal() is shared between raw and indexed profiles,
so I extended the function to take endian argument.

2. Failed on some profile tests

Some tests use different flags while instrumenting the code, and
compare the generated profiles via using diff. After adding
binary ids into profiles, the generated profiles have different
binary ids when they are compiled with different flags.
So, I updated the tests to compare the llvm-profdata show
result instead of directly comparing the profiles.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135929/new/

https://reviews.llvm.org/D135929

Files:
  compiler-rt/include/profile/InstrProfData.inc
  compiler-rt/test/profile/Linux/binary-id.c
  compiler-rt/test/profile/Linux/counter_promo_for.c
  compiler-rt/test/profile/Linux/counter_promo_nest.c
  compiler-rt/test/profile/Linux/counter_promo_while.c
  compiler-rt/test/profile/Linux/instrprof-debug-info-correlate.c
  llvm/include/llvm/ProfileData/InstrProf.h
  llvm/include/llvm/ProfileData/InstrProfData.inc
  llvm/include/llvm/ProfileData/InstrProfReader.h
  llvm/include/llvm/ProfileData/InstrProfWriter.h
  llvm/lib/ProfileData/InstrProf.cpp
  llvm/lib/ProfileData/InstrProfReader.cpp
  llvm/lib/ProfileData/InstrProfWriter.cpp
  llvm/tools/llvm-profdata/llvm-profdata.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135929.485558.patch
Type: text/x-patch
Size: 28359 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221229/96854ab8/attachment.bin>