[PATCH] D140741: [llvm-profdata] Remove unnecessary file size check

[William Junda Huang via Phabricator via llvm-commits]

huangjd created this revision.
Herald added subscribers: wenlei, hiraditya.
Herald added a project: All.
huangjd requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Unsure why profile reader checks profile size to be less than 4 GB. This breaks builds using a very large profile.
The limit is not seen anywhere else, so I am not sure why is it there in the first place.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140741

Files:
  llvm/lib/ProfileData/SampleProfReader.cpp


Index: llvm/lib/ProfileData/SampleProfReader.cpp
===================================================================
--- llvm/lib/ProfileData/SampleProfReader.cpp
+++ llvm/lib/ProfileData/SampleProfReader.cpp
@@ -1837,10 +1837,6 @@
     return EC;
   auto Buffer = std::move(BufferOrErr.get());
 
-  // Check the file.
-  if (uint64_t(Buffer->getBufferSize()) > std::numeric_limits<uint32_t>::max())
-    return sampleprof_error::too_large;
-
   return std::move(Buffer);
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140741.485543.patch
Type: text/x-patch
Size: 477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221228/c527e891/attachment.bin>