[PATCH] D140708: [AMDGPU][GFX908] Only consider explicit defs of src reg in indirect agpr copy

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 28 09:07:04 PST 2022


arsenm added a comment.

This isn’t the right place to apply optimizations. I’ve wanted to delete all of this code.

Copy lowering should be as straightforward as possible. What we have now is doing a liveness scan for each copy, which is crazy. We should either avoid this situation in the first place by applying implicit VGPR virtual register defs so the allocator  ensures one is free at this point, or optimize all the AGPR copies at once after the fact


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140708/new/

https://reviews.llvm.org/D140708



More information about the llvm-commits mailing list