[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

[Mariusz Ceier via Phabricator via llvm-commits]

mceier added a comment.

Checked the changes I'm suggesting and they fix the standalone build.



================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:650
+  .Case(NAME, FMV_PRIORITY)
+#include "../../../../llvm/include/llvm/TargetParser/AArch64TargetParser.def"
+      ;
----------------
That doesn't work for standalone builds. Instead maybe use `#include "llvm/TargetParser/AArch64TargetParser.def"` ?



================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:669
+  .Case(NAME, DEP_FEATURES)
+#include "../../../../llvm/include/llvm/TargetParser/AArch64TargetParser.def"
+                   .Default("");
----------------
Same comment as on line 650. `#include "llvm/TargetParser/AArch64TargetParser.def"` 


================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:679
+  .Case(NAME, llvm::AArch64::FEAT_##FMV_ID)
+#include "../../../../llvm/include/llvm/TargetParser/AArch64TargetParser.def"
+                      .Default(llvm::AArch64::FEAT_MAX);
----------------
Same comment as on line 650. `#include "llvm/TargetParser/AArch64TargetParser.def"` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127812/new/

https://reviews.llvm.org/D127812