[PATCH] D140702: [exegesis] "Skip codegen" dry-run mode
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 27 23:44:42 PST 2022
gchatelet added inline comments.
================
Comment at: llvm/docs/CommandGuide/llvm-exegesis.rst:210
+ In addition to `--skip-measurements`, also skips target machine code
+ generation for the snippets that would normally be executed and measured.
+
----------------
Maybe add that `--skip-codegen` implies `--skip-measurements` as defined later in the code.
================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h:40
+ bool BenchmarkSkipCodegen,
bool BenchmarkSkipMeasurements);
----------------
[nit] It's probably better to restructure the `BenchmarkRunner` to only run the benchmark instead of also being responsible for doing codegen.
Also passing multiple consecutive `bool` arguments seems like a red flag. Using an enum seems more compelling (since one flag implies the other).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140702/new/
https://reviews.llvm.org/D140702
More information about the llvm-commits
mailing list