[PATCH] D140382: [CodeGen] Add user interface for DetectDeadLanes

Piyou Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 27 05:44:28 PST 2022


BeMg marked 2 inline comments as done.
BeMg added inline comments.


================
Comment at: llvm/lib/CodeGen/DetectDeadLanes.cpp:499
+    bool LocalChanged;
+    std::tie(LocalChanged, Again) = runOnce(MF);
+    Changed |= LocalChanged;
----------------
craig.topper wrote:
> Do we need to skip the "Mark operands as dead/unused." part of runOnce for this usage?
I'm not sure whether "Mark operands as dead" is part of computing DeadLanes algorithm. And we remove "Mark operands as dead" may get an unaccomplished result?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140382/new/

https://reviews.llvm.org/D140382



More information about the llvm-commits mailing list