[PATCH] D133311: [Assignment Tracking][16/*] Account for assignment tracking in mldst-motion

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/mldst-motion/diamond.ll:22
+; CHECK: if.then:
+; CHECK-NEXT: call void @llvm.dbg.assign(metadata i32 1,{{.+}}, metadata !DIExpression(DW_OP_LLVM_fragment, 32, 32), metadata ![[ID:[0-9]+]], metadata ptr %1, metadata !DIExpression())
+
----------------
This looked a bit weird to me, so I want to double check that it is correct: %1 here is the new merged GEP inserted in the if.end block, while these dbg.assigns are in the if.then and if.else blocks. In other words, %1 does not dominate these dbg.assigns. Is that normal for debug intrinsics?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133311/new/

https://reviews.llvm.org/D133311