[llvm] 36df3fd - [Internalize] Convert tests to opaque pointers (NFC)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 27 01:54:55 PST 2022


Author: Nikita Popov
Date: 2022-12-27T10:54:35+01:00
New Revision: 36df3fd67b3a897bc50e36786f9b6cc239fb9f08

URL: https://github.com/llvm/llvm-project/commit/36df3fd67b3a897bc50e36786f9b6cc239fb9f08
DIFF: https://github.com/llvm/llvm-project/commit/36df3fd67b3a897bc50e36786f9b6cc239fb9f08.diff

LOG: [Internalize] Convert tests to opaque pointers (NFC)

Added: 
    

Modified: 
    llvm/test/Transforms/Internalize/2009-01-05-InternalizeAliases.ll
    llvm/test/Transforms/Internalize/comdat.ll
    llvm/test/Transforms/Internalize/local-visibility.ll
    llvm/test/Transforms/Internalize/used.ll
    llvm/test/Transforms/Internalize/vcall-visibility.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/Internalize/2009-01-05-InternalizeAliases.ll b/llvm/test/Transforms/Internalize/2009-01-05-InternalizeAliases.ll
index 88693130680b7..e724b055a05b3 100644
--- a/llvm/test/Transforms/Internalize/2009-01-05-InternalizeAliases.ll
+++ b/llvm/test/Transforms/Internalize/2009-01-05-InternalizeAliases.ll
@@ -3,14 +3,14 @@
 @A = global i32 0
 ; CHECK: @A = internal global i32 0
 
- at B = alias i32, i32* @A
-; CHECK: @B = internal alias i32, i32* @A
+ at B = alias i32, ptr @A
+; CHECK: @B = internal alias i32, ptr @A
 
- at C = alias i32, i32* @A
-; CHECK: @C = internal alias i32, i32* @A
+ at C = alias i32, ptr @A
+; CHECK: @C = internal alias i32, ptr @A
 
 define i32 @main() {
-	%tmp = load i32, i32* @C
+	%tmp = load i32, ptr @C
 	ret i32 %tmp
 }
 

diff  --git a/llvm/test/Transforms/Internalize/comdat.ll b/llvm/test/Transforms/Internalize/comdat.ll
index 05ea07aa14c54..2ad194bc7bf5a 100644
--- a/llvm/test/Transforms/Internalize/comdat.ll
+++ b/llvm/test/Transforms/Internalize/comdat.ll
@@ -33,14 +33,14 @@ $c5 = comdat any
 ; CHECK: @c4_a = internal global i32 0, comdat($c4)
 @c4_a = internal global i32 0, comdat($c4)
 
-; CHECK: @c1_d = alias i32, i32* @c1_c
- at c1_d = alias i32, i32* @c1_c
+; CHECK: @c1_d = alias i32, ptr @c1_c
+ at c1_d = alias i32, ptr @c1_c
 
-; CHECK: @c2_c = internal alias i32, i32* @c2_b
- at c2_c = alias i32, i32* @c2_b
+; CHECK: @c2_c = internal alias i32, ptr @c2_b
+ at c2_c = alias i32, ptr @c2_b
 
-; CHECK: @c4 = alias i32, i32* @c4_a
- at c4 = alias i32, i32* @c4_a
+; CHECK: @c4 = alias i32, ptr @c4_a
+ at c4 = alias i32, ptr @c4_a
 
 ; CHECK: define void @c1() comdat {
 define void @c1() comdat {

diff  --git a/llvm/test/Transforms/Internalize/local-visibility.ll b/llvm/test/Transforms/Internalize/local-visibility.ll
index b341d8a7605f0..995804e06f18c 100644
--- a/llvm/test/Transforms/Internalize/local-visibility.ll
+++ b/llvm/test/Transforms/Internalize/local-visibility.ll
@@ -3,17 +3,17 @@
 
 ; CHECK: @global = global i32 0
 @global = global i32 0
- at llvm.used = appending global [1 x i32*] [i32* @global]
+ at llvm.used = appending global [1 x ptr] [ptr @global]
 
 ; CHECK: @hidden.variable = internal global i32 0
 @hidden.variable = hidden global i32 0
 ; CHECK: @protected.variable = internal global i32 0
 @protected.variable = protected global i32 0
 
-; CHECK: @hidden.alias = internal alias  i32,  i32* @global
- at hidden.alias = hidden alias i32, i32* @global
-; CHECK: @protected.alias = internal alias i32, i32* @global
- at protected.alias = protected alias i32, i32* @global
+; CHECK: @hidden.alias = internal alias  i32,  ptr @global
+ at hidden.alias = hidden alias i32, ptr @global
+; CHECK: @protected.alias = internal alias i32, ptr @global
+ at protected.alias = protected alias i32, ptr @global
 
 ; CHECK: define internal void @hidden.function() {
 define hidden void @hidden.function() {

diff  --git a/llvm/test/Transforms/Internalize/used.ll b/llvm/test/Transforms/Internalize/used.ll
index ff6d0527df93d..b22134b1bcf9d 100644
--- a/llvm/test/Transforms/Internalize/used.ll
+++ b/llvm/test/Transforms/Internalize/used.ll
@@ -1,8 +1,8 @@
 ; RUN: opt < %s -passes=internalize -S | FileCheck %s
 
- at llvm.used = appending global [1 x void ()*] [void ()* @f], section "llvm.metadata"
+ at llvm.used = appending global [1 x ptr] [ptr @f], section "llvm.metadata"
 
- at llvm.compiler.used = appending global [1 x void ()*] [void ()* @g], section "llvm.metadata"
+ at llvm.compiler.used = appending global [1 x ptr] [ptr @g], section "llvm.metadata"
 
 ; CHECK: define void @f()
 define void @f() {

diff  --git a/llvm/test/Transforms/Internalize/vcall-visibility.ll b/llvm/test/Transforms/Internalize/vcall-visibility.ll
index ea28aeba051bb..c2fe8c3a01e9a 100644
--- a/llvm/test/Transforms/Internalize/vcall-visibility.ll
+++ b/llvm/test/Transforms/Internalize/vcall-visibility.ll
@@ -1,53 +1,52 @@
 ; RUN: opt < %s -passes=internalize -S | FileCheck %s
 
-%struct.A = type { i32 (...)** }
-%struct.B = type { i32 (...)** }
-%struct.C = type { i32 (...)** }
+%struct.A = type { ptr }
+%struct.B = type { ptr }
+%struct.C = type { ptr }
 
 ; Class A has default visibility, so has no !vcall_visibility metadata before
 ; or after LTO.
 ; CHECK-NOT: @_ZTV1A = {{.*}}!vcall_visibility
- at _ZTV1A = dso_local unnamed_addr constant { [3 x i8*] } { [3 x i8*] [i8* null, i8* null, i8* bitcast (void (%struct.A*)* @_ZN1A3fooEv to i8*)] }, align 8, !type !0, !type !1
+ at _ZTV1A = dso_local unnamed_addr constant { [3 x ptr] } { [3 x ptr] [ptr null, ptr null, ptr @_ZN1A3fooEv] }, align 8, !type !0, !type !1
 
 ; Class B has hidden visibility but public LTO visibility, so has no
 ; !vcall_visibility metadata before or after LTO.
 ; CHECK-NOT: @_ZTV1B = {{.*}}!vcall_visibility
- at _ZTV1B = hidden unnamed_addr constant { [3 x i8*] } { [3 x i8*] [i8* null, i8* null, i8* bitcast (void (%struct.B*)* @_ZN1B3fooEv to i8*)] }, align 8, !type !2, !type !3
+ at _ZTV1B = hidden unnamed_addr constant { [3 x ptr] } { [3 x ptr] [ptr null, ptr null, ptr @_ZN1B3fooEv] }, align 8, !type !2, !type !3
 
 ; Class C has hidden visibility, so the !vcall_visibility metadata is set to 1
 ; (linkage unit) before LTO, and 2 (translation unit) after LTO.
 ; CHECK: @_ZTV1C ={{.*}}!vcall_visibility [[MD_TU_VIS:![0-9]+]]
- at _ZTV1C = hidden unnamed_addr constant { [3 x i8*] } { [3 x i8*] [i8* null, i8* null, i8* bitcast (void (%struct.C*)* @_ZN1C3fooEv to i8*)] }, align 8, !type !4, !type !5, !vcall_visibility !6
+ at _ZTV1C = hidden unnamed_addr constant { [3 x ptr] } { [3 x ptr] [ptr null, ptr null, ptr @_ZN1C3fooEv] }, align 8, !type !4, !type !5, !vcall_visibility !6
 
 ; Class D has translation unit visibility before LTO, and this is not changed
 ; by LTO.
 ; CHECK: @_ZTVN12_GLOBAL__N_11DE = {{.*}}!vcall_visibility [[MD_TU_VIS:![0-9]+]]
- at _ZTVN12_GLOBAL__N_11DE = internal unnamed_addr constant { [3 x i8*] } zeroinitializer, align 8, !type !7, !type !9, !vcall_visibility !11
+ at _ZTVN12_GLOBAL__N_11DE = internal unnamed_addr constant { [3 x ptr] } zeroinitializer, align 8, !type !7, !type !9, !vcall_visibility !11
 
-define dso_local void @_ZN1A3fooEv(%struct.A* nocapture %this) {
+define dso_local void @_ZN1A3fooEv(ptr nocapture %this) {
 entry:
   ret void
 }
 
-define hidden void @_ZN1B3fooEv(%struct.B* nocapture %this) {
+define hidden void @_ZN1B3fooEv(ptr nocapture %this) {
 entry:
   ret void
 }
 
-define hidden void @_ZN1C3fooEv(%struct.C* nocapture %this) {
+define hidden void @_ZN1C3fooEv(ptr nocapture %this) {
 entry:
   ret void
 }
 
-define hidden noalias nonnull i8* @_Z6make_dv() {
+define hidden noalias nonnull ptr @_Z6make_dv() {
 entry:
-  %call = tail call i8* @_Znwm(i64 8) #3
-  %0 = bitcast i8* %call to i32 (...)***
-  store i32 (...)** bitcast (i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }* @_ZTVN12_GLOBAL__N_11DE, i64 0, inrange i32 0, i64 2) to i32 (...)**), i32 (...)*** %0, align 8
-  ret i8* %call
+  %call = tail call ptr @_Znwm(i64 8) #3
+  store ptr getelementptr inbounds ({ [3 x ptr] }, ptr @_ZTVN12_GLOBAL__N_11DE, i64 0, inrange i32 0, i64 2), ptr %call, align 8
+  ret ptr %call
 }
 
-declare dso_local noalias nonnull i8* @_Znwm(i64)
+declare dso_local noalias nonnull ptr @_Znwm(i64)
 
 ; CHECK: [[MD_TU_VIS]] = !{i64 2}
 !0 = !{i64 16, !"_ZTS1A"}


        


More information about the llvm-commits mailing list