[PATCH] D140528: [msan] Add msan support for loongarch64

Youling Tang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 26 18:51:00 PST 2022


tangyouling added inline comments.


================
Comment at: compiler-rt/lib/msan/msan.h:171
 
 #elif SANITIZER_NETBSD || (SANITIZER_LINUX && SANITIZER_WORDSIZE == 64)
 
----------------
SixWeining wrote:
> We fall to this? But not line 208?
I will move the contents of line 208 to line 91.


================
Comment at: compiler-rt/test/msan/mmap.cpp:22-24
+  return (addr >= 0x000000000000ULL && addr < 0x010000000000ULL) ||
+         (addr >= 0x510000000000ULL && addr < 0x600000000000ULL) ||
+         (addr >= 0x700000000000ULL && addr < 0x800000000000ULL);
----------------
SixWeining wrote:
> These addresses are the same as x86_64 above. Is this expected?
Because the app-{1,2,3} definition of kMemoryLayout is consistent with x86_64, it is the same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140528/new/

https://reviews.llvm.org/D140528



More information about the llvm-commits mailing list