[PATCH] D139807: [lld][ELF] Support relocation R_AVR_LDS_STS_16 on AVRTiny devices.

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 26 18:40:10 PST 2022


benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: lld/test/ELF/avr-reloc.s:84
+; HEX:         {{.*}} 40911e00 50931e00
+lds r20, b  ; R_AVR_LDS_STS_16
+sts b, r21  ; R_AVR_LDS_STS_16
----------------
aykevl wrote:
> benshi001 wrote:
> > `lds/sts` are 32-bit instructions on non avrtiny devices.
> Why does the comment say `R_AVR_LDS_STS_16` for atmega328p? (Sounds like a copy/paste error)
Thanks. I have corrected them. llvm emits relocation `R_AVR_16` for `lds`/`sts` on AVR while `R_AVR_LDS_STS_16` on AVRTiny.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139807/new/

https://reviews.llvm.org/D139807



More information about the llvm-commits mailing list