[PATCH] D139785: [InstCombine] preserve signbit semantics of NAN with fold to fabs

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 26 13:09:14 PST 2022


lebedev.ri added a comment.

In D139785#4016958 <https://reviews.llvm.org/D139785#4016958>, @lebedev.ri wrote:

> In D139785#4016957 <https://reviews.llvm.org/D139785#4016957>, @spatel wrote:
>
>> In D139785#4016955 <https://reviews.llvm.org/D139785#4016955>, @lebedev.ri wrote:
>>
>>> Could you add a relevant quote of the IEE spec into the description,
>>> and add an example with +NaN and -NaN and describe the outcome (kinda like alive2 counter-example)?
>>
>> Sure - see updated text. Let me know if you'd like to see something else or different.
>
> Consider also adding https://godbolt.org/z/h9aefnKhE

Err, more like https://godbolt.org/z/1h161jEEj


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139785/new/

https://reviews.llvm.org/D139785



More information about the llvm-commits mailing list