[PATCH] D140569: [AVR] Custom lower 32-bit shift instructions

[Ben Shi via Phabricator via llvm-commits]

benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:1847
+    // Shift one to the left.
+    for (size_t i = 0; i < Regs.size(); i++) {
+      size_t Idx = Regs.size() - i - 1;
----------------
aykevl wrote:
> benshi001 wrote:
> > Would it be better to be 
> > ```
> > for (ssize_t i = Regs.size() - 1; i >= 0; i--) {
> >  ...
> >  if (i == Regs.size() - 1) {
> >    ...
> >   } else {
> >    ...
> >   }
> > }
> > ```
> Fixed locally.
I saw you use captical loop variable `I` in your other patch, https://reviews.llvm.org/D140570, maybe it would be better to also use `I` instead of `i` here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140569/new/

https://reviews.llvm.org/D140569