[PATCH] D139927: [VPlan] Remove redundant blocks by merging them into predecessors.

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:328
+      VPBlockUtils::disconnectBlocks(VPBB, Succ);
+      VPBlockUtils::connectBlocks(PredVPBB, Succ);
+    }
----------------
Q1: Can VPBB be a successor of itself? If it can, this is probably fine, as we (1) shouldn't reach here (unless VPBB is unreachable) and (2) reconnecting it to itself should do no harm as it is going to be deleted anyway. Worth asserting?
Q2: Can VPBB have references other than control flow edges? I'm asking because I see `VPBasicBlock::dropAllReferences` interface.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139927/new/

https://reviews.llvm.org/D139927