[PATCH] D139927: [VPlan] Remove redundant blocks by merging them into predecessors.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 25 12:34:12 PST 2022
fhahn marked 3 inline comments as done.
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9170
- // TODO: Fold block earlier once all VPlan transforms properly maintain a
- // VPBasicBlock as exit.
- VPBlockUtils::tryToMergeBlockIntoPredecessor(TopRegion->getExiting());
----------------
Ayal wrote:
> nit: not sure what is meant here by "earlier" or improper maintenance of VPlan transforms?
I think this mainly referred to doing mergeBlocksIntoPredecessors on 2 individual blocks here and immediately after constructing the initial recipes. The latter has been removed as well now
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139927/new/
https://reviews.llvm.org/D139927
More information about the llvm-commits
mailing list