[PATCH] D140555: [lld][COFF]llvm-readobj COFFDumper print PEHeader CheckSum

[Qfrost via Phabricator via llvm-commits]

Qfrost911 updated this revision to Diff 484996.
Qfrost911 added a comment.

Oh, right, but I see there is only an error which in file-headers.test can be raised.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140555/new/

https://reviews.llvm.org/D140555

Files:
  lld/test/COFF/hello32.test
  llvm/test/tools/llvm-readobj/COFF/file-headers.test
  llvm/tools/llvm-readobj/COFFDumper.cpp


Index: llvm/tools/llvm-readobj/COFFDumper.cpp
===================================================================
--- llvm/tools/llvm-readobj/COFFDumper.cpp
+++ llvm/tools/llvm-readobj/COFFDumper.cpp
@@ -737,6 +737,7 @@
   W.printNumber("MinorSubsystemVersion", Hdr->MinorSubsystemVersion);
   W.printNumber("SizeOfImage", Hdr->SizeOfImage);
   W.printNumber("SizeOfHeaders", Hdr->SizeOfHeaders);
+  W.printNumber("CheckSum", Hdr->CheckSum);
   W.printEnum  ("Subsystem", Hdr->Subsystem, makeArrayRef(PEWindowsSubsystem));
   W.printFlags ("Characteristics", Hdr->DLLCharacteristics,
                 makeArrayRef(PEDLLCharacteristics));
Index: llvm/test/tools/llvm-readobj/COFF/file-headers.test
===================================================================
--- llvm/test/tools/llvm-readobj/COFF/file-headers.test
+++ llvm/test/tools/llvm-readobj/COFF/file-headers.test
@@ -152,6 +152,7 @@
 # I386-CUSTOM-HEADER-NEXT:  MinorSubsystemVersion: 0
 # I386-CUSTOM-HEADER-NEXT:  SizeOfImage: 4096
 # I386-CUSTOM-HEADER-NEXT:  SizeOfHeaders: 512
+# I386-CUSTOM-HEADER-NEXT:  CheckSum:
 # I386-CUSTOM-HEADER-NEXT:  Subsystem: IMAGE_SUBSYSTEM_WINDOWS_CUI (0x3)
 # I386-CUSTOM-HEADER-NEXT:  Characteristics [ (0x8140)
 # I386-CUSTOM-HEADER-NEXT:    IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE (0x40)
Index: lld/test/COFF/hello32.test
===================================================================
--- lld/test/COFF/hello32.test
+++ lld/test/COFF/hello32.test
@@ -42,6 +42,7 @@
 HEADER-NEXT:   MinorSubsystemVersion: 0
 HEADER-NEXT:   SizeOfImage: 20480
 HEADER-NEXT:   SizeOfHeaders: 1024
+HEADER-NEXT:   CheckSum:
 HEADER-NEXT:   Subsystem: IMAGE_SUBSYSTEM_WINDOWS_CUI (0x3)
 HEADER-NEXT:   Characteristics [ (0x9140)
 HEADER-NEXT:     IMAGE_DLL_CHARACTERISTICS_APPCONTAINER (0x1000)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140555.484996.patch
Type: text/x-patch
Size: 1782 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221223/96dddb9c/attachment.bin>